[Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration

[Pali Rohár]

On Thursday 23 April 2015 23:04:22 Jose Fonseca wrote:
> On 23/04/15 18:46, Pali Rohár wrote:
> > On Monday 13 April 2015 22:35:03 Pali Rohár wrote:
> >> On Monday 13 April 2015 22:32:10 Brian Paul wrote:
> >>> On 04/13/2015 01:49 PM, Pali Rohár wrote:
> >>>> On Monday 13 April 2015 21:26:32 Pali Rohár wrote:
> >>>>> File glapi_entrypoint.c calls memcpy() function, but
> >>>>> does not include string.h header. So compilation can
> >>>>> fail at error: implicit declaration of function
> >>>>> 'memcpy'.
> >>>>> 
> >>>>> --- src/mapi/glapi/glapi_entrypoint.c	2015-04-13
> >>>>> 21:11:09.000000000 +0200 +++
> >>>>> src/mapi/glapi/glapi_entrypoint.c	2015-04-13
> >>>>> 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@
> >>>>> 
> >>>>>    #include "glapi/glapi_priv.h"
> >>>>>    #include "u_execmem.h"
> >>>>> 
> >>>>> +#include <string.h>
> >>>>> 
> >>>>>    #ifdef USE_X86_ASM
> >>>> 
> >>>> This problem is caused by commit:
> >>>> 
> >>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.
> >>>> fre
> >>>> edesktop.org_mesa_mesa_commit_-3Fid-3D9fbbd60c1da4467683
> >>>> d935
> >>>> 40c64164ad337ce454&d=AwIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXV
> >>>> eAw-
> >>>> YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbom
> >>>> Vj8&
> >>>> m=cHbB4rMFT3az-q-Y6KO11a04PyYTYhOCPMZ3PAFmyds&s=lvCbo4YT
> >>>> BIN1 5kh-3Wu1-rQAsyFcdKtCE-Ywc4u_mug&e=
> >>>> 
> >>>> which removes #include <string.h> from glapi_priv.h file.
> >>> 
> >>> What configure or autogen.sh options did you use?  I
> >>> haven't seen this on any of my systems.
> >>> 
> >>> -Brian
> >> 
> >> If it helps here is full build log with error message:
> >> 
> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__launch
> >> padlibrarian.net_203127592_buildlog-5Fubuntu-2Dprecise-2Di3
> >> 86.mesa-5F10.6.0-2Dgit201504131208.36ceda4-7Eubuntu12.04.1-
> >> 5FBUILDING.txt.gz&d=AwIDaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> >> YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE
> >> &m=APogfpCq-vsnsGAuf6IWkOzXLZ4dY83aVZTYvsJsdtI&s=6SlGiWJZZs
> >> OV1qK8l0vLE5nJaRUhJn0DTwSw2hQdbXA&e=
> >> 
> >> Its compiled on Ubuntu 12.04 Precise box.
> > 
> > Hello, this problem is still not fixed and compilation from
> > git still failing... Please can you look at it and include
> > missing string.h file? It is obvious problem in mesa and I
> > also found which commit broke compilation...
> 
> I pushed your fix.  Sorry for the delay.  It wasn't
> intentional. There's so much traffic in Mesa, it's easy for
> things to fall through cracks.
> 
> Jose

Thanks. Now compilation from git working fine...

-- 
Pali Rohár
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150424/63e3ede9/attachment.sig>