[Mesa-dev] [PATCH 1/4] Revert "i965/fs: Allow SIMD16 borrow/carry/64-bit multiply on Gen > 7."

[Kenneth Graunke]

On Friday, April 24, 2015 11:28:03 AM Matt Turner wrote:
> This reverts commit 9f5e5bd34d8ba48c851b442fb88f742b1ba6a571.
> 
> I have no idea what made me believe these didn't apply to Gen > 7. They
> do, and without them we generate bad code that causes failures on Gen 8.
> ---
>  src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> index 11f38c2..cf59570 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> @@ -892,7 +892,7 @@ fs_visitor::visit(ir_expression *ir)
>        }
>        break;
>     case ir_binop_imul_high: {
> -      if (devinfo->gen == 7)
> +      if (devinfo->gen >= 7)
>           no16("SIMD16 explicit accumulator operands unsupported\n");
>  
>        struct brw_reg acc = retype(brw_acc_reg(dispatch_width),
> @@ -929,7 +929,7 @@ fs_visitor::visit(ir_expression *ir)
>        emit_math(SHADER_OPCODE_INT_QUOTIENT, this->result, op[0], op[1]);
>        break;
>     case ir_binop_carry: {
> -      if (devinfo->gen == 7)
> +      if (devinfo->gen >= 7)
>           no16("SIMD16 explicit accumulator operands unsupported\n");
>  
>        struct brw_reg acc = retype(brw_acc_reg(dispatch_width),
> @@ -940,7 +940,7 @@ fs_visitor::visit(ir_expression *ir)
>        break;
>     }
>     case ir_binop_borrow: {
> -      if (devinfo->gen == 7)
> +      if (devinfo->gen >= 7)
>           no16("SIMD16 explicit accumulator operands unsupported\n");
>  
>        struct brw_reg acc = retype(brw_acc_reg(dispatch_width),
> 

Series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150424/f69b604f/attachment.sig>