[Mesa-dev] [PATCH] Fix 32bit compilation with -Werror=implicit-function-declaration

[Pali Rohár]

On Monday 13 April 2015 22:35:03 Pali Rohár wrote:
> On Monday 13 April 2015 22:32:10 Brian Paul wrote:
> > On 04/13/2015 01:49 PM, Pali Rohár wrote:
> > > On Monday 13 April 2015 21:26:32 Pali Rohár wrote:
> > >> File glapi_entrypoint.c calls memcpy() function, but does
> > >> not include string.h header. So compilation can fail at
> > >> error: implicit declaration of function 'memcpy'.
> > >> 
> > >> --- src/mapi/glapi/glapi_entrypoint.c	2015-04-13
> > >> 21:11:09.000000000 +0200 +++
> > >> src/mapi/glapi/glapi_entrypoint.c	2015-04-13
> > >> 21:11:55.284118513 +0200 @@ -33,6 +33,7 @@
> > >> 
> > >>   #include "glapi/glapi_priv.h"
> > >>   #include "u_execmem.h"
> > >> 
> > >> +#include <string.h>
> > >> 
> > >>   #ifdef USE_X86_ASM
> > > 
> > > This problem is caused by commit:
> > > 
> > > https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.fre
> > > edesktop.org_mesa_mesa_commit_-3Fid-3D9fbbd60c1da4467683d935
> > > 40c64164ad337ce454&d=AwIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> > > YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&
> > > m=cHbB4rMFT3az-q-Y6KO11a04PyYTYhOCPMZ3PAFmyds&s=lvCbo4YTBIN1
> > > 5kh-3Wu1-rQAsyFcdKtCE-Ywc4u_mug&e=
> > > 
> > > which removes #include <string.h> from glapi_priv.h file.
> > 
> > What configure or autogen.sh options did you use?  I haven't
> > seen this on any of my systems.
> > 
> > -Brian
> 
> If it helps here is full build log with error message:
> 
> https://launchpadlibrarian.net/203127592/buildlog_ubuntu-precise-i386.mesa_10.6.0-git201504131208.36ceda4~ubuntu12.04.1_BUILDING.txt.gz
> 
> Its compiled on Ubuntu 12.04 Precise box.
> 

Hello, this problem is still not fixed and compilation from git still
failing... Please can you look at it and include missing string.h file?
It is obvious problem in mesa and I also found which commit broke
compilation...

-- 
Pali Rohár
pali.rohar at gmail.com