[Mesa-dev] [PATCH] i965: Add an INTEL_DEBUG=spill option to test spilling

[Jordan Justen]

On 2015-04-23 12:01:41, Ilia Mirkin wrote:
> On Thu, Apr 23, 2015 at 2:50 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> > diff --git a/src/mesa/drivers/dri/i965/intel_debug.h b/src/mesa/drivers/dri/i965/intel_debug.h
> > index 807ad98..e5af998 100644
> > --- a/src/mesa/drivers/dri/i965/intel_debug.h
> > +++ b/src/mesa/drivers/dri/i965/intel_debug.h
> > @@ -64,6 +64,7 @@ extern uint64_t INTEL_DEBUG;
> >  #define DEBUG_ANNOTATION          (1 << 28)
> >  #define DEBUG_NO8                 (1 << 29)
> >  #define DEBUG_VEC4VS              (1 << 30)
> > +#define DEBUG_SPILL               (1l << 31)
> 
> That seems awkward... did you mean 1U? FWIW mesa's not at all careful
> about that...

Yeah, I agree. 1l is awkward.

But I think 1U is just unsigned. I don't think that is guaranteed to
be 64-bit.

Wouldn't 1ULL be what we want? In brw_context.h we use 'ull' in a
similar scenario. I prefer the upper case version because it stands
out better, and avoids the l/1 confusion.

With 1ULL (or 1ull)
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

-Jordan