[Mesa-dev] [PATCH] clover: compile all sources with c++11

[EdB]

On Tuesday 21 April 2015 12:54:28 Emil Velikov wrote:
> On 20/04/15 21:34, EdB wrote:
> > Later we can remove the compat code.
> > ---
> > 
> >  src/gallium/state_trackers/clover/Makefile.am | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/src/gallium/state_trackers/clover/Makefile.am
> > b/src/gallium/state_trackers/clover/Makefile.am
> > index 62c13fa..54b6fff 100644
> > --- a/src/gallium/state_trackers/clover/Makefile.am
> > +++ b/src/gallium/state_trackers/clover/Makefile.am
> > @@ -3,6 +3,7 @@ AUTOMAKE_OPTIONS = subdir-objects
> > 
> >  include Makefile.sources
> >  
> >  AM_CPPFLAGS = \
> > 
> > +       -std=c++11 \
> 
> Strictly speaking this should is not part of the pre-processor flags and
> one should use the CXXFLAGS variable(s). Barring any bugs things should
> work as is, so I'll leave the decision up-to you :-)

Thanks, I'll change that in a v2
> 
> >         $(GALLIUM_PIPE_LOADER_DEFINES) \
> >         -DPIPE_SEARCH_DIR=\"$(libdir)/gallium-pipe\" \
> >         -I$(top_srcdir)/include \
> > 
> > @@ -35,7 +36,6 @@ endif
> > 
> >  noinst_LTLIBRARIES = libclover.la libcltgsi.la libclllvm.la
> 
> Now that all the code is built with c++11 does not make sense the have
> three separate static libraries ?

According to Francisco Jerez, it happen that some time llvm requiring exotic 
compilation flags and it would be preferable not to to contaminate the rest of 
clover build

> 
> Thanks
> Emil