[Mesa-dev] [PATCH] i965: Add marketing names for CHV

Ville Syrjälä ville.syrjala at linux.intel.com
Thu Apr 16 11:29:04 PDT 2015


On Thu, Apr 16, 2015 at 11:20:01AM -0700, Kenneth Graunke wrote:
> On Thursday, April 16, 2015 09:00:46 PM ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > All CHV devices will be branded as "Intel(r) HD Graphics".
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > ---
> >  include/pci_ids/i965_pci_ids.h | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h
> > index 3e3e8fe..8d757aa 100644
> > --- a/include/pci_ids/i965_pci_ids.h
> > +++ b/include/pci_ids/i965_pci_ids.h
> > @@ -124,7 +124,7 @@ CHIPSET(0x1921, skl_gt2, "Intel(R) Skylake ULT GT2F")
> >  CHIPSET(0x1926, skl_gt3, "Intel(R) Skylake ULT GT3")
> >  CHIPSET(0x192A, skl_gt3, "Intel(R) Skylake SRV GT3")
> >  CHIPSET(0x192B, skl_gt3, "Intel(R) Skylake Halo GT3")
> > -CHIPSET(0x22B0, chv,     "Intel(R) Cherryview")
> > -CHIPSET(0x22B1, chv,     "Intel(R) Cherryview")
> > -CHIPSET(0x22B2, chv,     "Intel(R) Cherryview")
> > -CHIPSET(0x22B3, chv,     "Intel(R) Cherryview")
> > +CHIPSET(0x22B0, chv,     "Intel(R) HD Graphics (Cherryview)")
> > +CHIPSET(0x22B1, chv,     "Intel(R) HD Graphics (Cherryview)")
> > +CHIPSET(0x22B2, chv,     "Intel(R) HD Graphics (Cherryview)")
> > +CHIPSET(0x22B3, chv,     "Intel(R) HD Graphics (Cherryview)")
> > 
> 
> Thank you for leaving Cherryview here - I like to have that there so
> it's unique and identifiable.

Yep, that was my thinking as well. Otherwise we'd have just a bazillion
"HD Graphics" entries and everyone would be even more confused.

> 
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Thanks.

-- 
Ville Syrjälä
Intel OTC


More information about the mesa-dev mailing list