[Mesa-dev] [PATCH] glx: Create proper server dependency for GLX_EXT_create_context_es2_profile

[Emil Velikov]

On 14 April 2015 at 17:35, Ian Romanick <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Previously GLX_EXT_create_context_es2_profile was marked as "direct
> only" so that it would not depend on server support.  Since the
> extension required functions that are part of
> GLX_ARB_create_context_profile, support for the EXT was disabled if the
> ARB was not supported.
>
> This was complete rubbish.  If the server supported the ARB but not the
> EXT, sending a request with GLX_CONTEXT_ES2_PROFILE_BIT_EXT would result
> in GLXBadProfileARB.
>
> Instead of the misguided hack, make GLX_EXT_create_context_es2_profile
> properly depend on server support by not marking it as "direct only."
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: José Fonseca <jfonseca at vmware.com>
> Cc: Chad Versace <chad.versace at intel.com>
> Cc: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  src/glx/glxextensions.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/src/glx/glxextensions.c b/src/glx/glxextensions.c
> index ce5d66d..a326f0d 100644
> --- a/src/glx/glxextensions.c
> +++ b/src/glx/glxextensions.c
> @@ -84,7 +84,7 @@ static const struct extension_info known_glx_extensions[] = {
>     { GLX(EXT_visual_rating),           VER(0,0), Y, Y, N, N },
>     { GLX(EXT_fbconfig_packed_float),   VER(0,0), Y, Y, N, N },
>     { GLX(EXT_framebuffer_sRGB),        VER(0,0), Y, Y, N, N },
> -   { GLX(EXT_create_context_es2_profile), VER(0,0), Y, N, N, Y },
> +   { GLX(EXT_create_context_es2_profile), VER(0,0), Y, N, N, N },
I've had a look at these a while back, and I don't think I ever got
the idea how an extension can be direct_only without having
direct_support. If you can spare a minute that would be greatly
appreciated, the glx code can be a bit misty at times.

Thanks
Emil