[Mesa-dev] [PATCH 1/4] gallium/ttn: add support for texture offsets

[Rob Clark]

On Tue, Apr 14, 2015 at 1:04 PM, Eric Anholt <eric at anholt.net> wrote:
> Rob Clark <robdclark at gmail.com> writes:
>
>> From: Rob Clark <robclark at freedesktop.org>
>>
>> Signed-off-by: Rob Clark <robclark at freedesktop.org>
>
> 1-3 (with the fix to 1 that you posted in irc) are:
>
> Reviewed-by: Eric Anholt <eric at anholt.net>
>
> I don't like the mismatch on bytes vs vec4s in the load_ubo_indirect
> arguments for patch 4, and will be interested in seeing the version you
> were working on to fix that.

so, if I pull out the addressing-modes patch, then for the ubo patch
we are back to 'index *= 16' vec4->byte conversion.  Which is funny
looking, but at the moment my best definition of "correct" is "what
glsl_to_nir and intel driver do", and by that definition, this is the
correct thing to do.

BR,
-R