[Mesa-dev] [PATCH 2/2] configure.ac: add --enable-assertions

Emil Velikov emil.l.velikov at gmail.com
Tue Apr 14 05:13:43 PDT 2015


Hi Marek

On 13 April 2015 at 21:06, Marek Olšák <maraeo at gmail.com> wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> ---
>  configure.ac | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 6ccf3b4..f5eeb7d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -402,6 +402,13 @@ AC_ARG_ENABLE([debug],
>      [enable_debug="$enableval"],
>      [enable_debug=no]
>  )
> +AC_ARG_ENABLE([assertions],
> +    [AS_HELP_STRING([--enable-assertions],
> +        [add debug definitions to enable assertions and other debug checks @<:@default=disabled@:>@])],
Can we keep this only for asserts (NDEBUG) as the name suggests ?
Otherwise things might get bit too messy when combining with
--enable-debug. Especially since most places of mesa reply on DEBUG,
while the asserts definition depends on NDEBUG.

Thanks
Emil


More information about the mesa-dev mailing list