[Mesa-dev] [PATCH 1/4] nir: Fix bug in handling non-SSA copy prop of indirect register access.

[Connor Abbott]

Patches 1 and 2 are

Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>

Adding stricter assertions for tex sources makes sense to me now after
some thought/discussion, but if we're going to do it then we should go
all the way and make intrinsic srcs and dests and if srcs more strict
as well. Also, maybe you've done this already, but especially after
doing that we should piglit i965 since it uses a different path to
generate NIR -- I wouldn't expect any regressions though.

Connor


On Mon, Apr 13, 2015 at 4:36 PM, Eric Anholt <eric at anholt.net> wrote:
> The intention was to not copy propagate this source (which has some
> variable access), but instead copy propagate its variable offset value.
> ---
>  src/glsl/nir/nir_opt_copy_propagate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl/nir/nir_opt_copy_propagate.c b/src/glsl/nir/nir_opt_copy_propagate.c
> index ee78e5a..027143e 100644
> --- a/src/glsl/nir/nir_opt_copy_propagate.c
> +++ b/src/glsl/nir/nir_opt_copy_propagate.c
> @@ -154,7 +154,7 @@ copy_prop_src(nir_src *src, nir_instr *parent_instr, nir_if *parent_if)
>  {
>     if (!src->is_ssa) {
>        if (src->reg.indirect)
> -         return copy_prop_src(src, parent_instr, parent_if);
> +         return copy_prop_src(src->reg.indirect, parent_instr, parent_if);
>        return false;
>     }
>
> --
> 2.1.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev