[Mesa-dev] [PATCH 4/7] i965: Add field intel_mipmap_tree::disable_aux_buffers

Chad Versace chad.versace at intel.com
Mon Apr 13 07:33:55 PDT 2015


On Fri 10 Apr 2015, Pohjolainen, Topi wrote:
>On Thu, Apr 09, 2015 at 08:57:05PM -0700, Chad Versace wrote:

>> @@ -440,6 +451,10 @@ intel_miptree_create_layout(struct brw_context *brw,
>>
>>     brw_miptree_layout(brw, mt);
>>
>> +   if (mt->disable_aux_buffers) {
>> +      assert(mt->msaa_layout != INTEL_MSAA_LAYOUT_CMS);
>> +   }
>> +
>
>Top level, you could leave {} out, just as you did in the rest of the
>patch.

I'll change that to be consistent with the reset of the patch before
I push.

>
>Functional wise I can't see anything amiss. I really appreciate the added
>assertions, makes it easier to see that runtime behaviour is as before:
>
>Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>


More information about the mesa-dev mailing list