[Mesa-dev] [PATCH v2 04/24] mesa: glGetProgramInterfaceiv

[Martin Peres]

On 13/04/15 12:34, Tapani Pälli wrote:
>
>
> On 04/13/2015 12:27 PM, Martin Peres wrote:
>> On 01/04/15 15:14, Tapani Pälli wrote:
>>> Patch adds required helper functions to shaderapi.h and
>>> the actual implementation.
>>>
>>> v2: code cleanup (Ilia Mirkin)
>>>      fix array size fo xfb varyings
>>>      validate programInterface and throw error
>>>
>>> corresponding Piglit test:
>>>     arb_program_interface_query-getprograminterfaceiv
>>>
>>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>>> ---
>>>   src/mesa/main/program_resource.c | 119
>>> +++++++++++++++++++++++++++++++++++++++
>>>   src/mesa/main/shader_query.cpp   |  59 +++++++++++++++++++
>>>   src/mesa/main/shaderapi.h        |   7 +++
>>>   3 files changed, 185 insertions(+)
>>>
>>> diff --git a/src/mesa/main/program_resource.c
>>> b/src/mesa/main/program_resource.c
>>> index b3b93aa..0da934a 100644
>
> 8<
>
>>> +            }
>>> +         }
>>> +         break;
>>> +      case GL_MAX_NUM_COMPATIBLE_SUBROUTINES:
>> Why did you add GL_MAX_NUM_COMPATIBLE_SUBROUTINE here?
>
> That's just a placeholder helper for the guy who will implement 
> subroutine support and grep for this enum in some distant future.

Ack, but why this one only?