[Mesa-dev] [PATCH] configure.ac: enable non-gallium assertions for people not using --enable-debug

Marek Olšák maraeo at gmail.com
Sun Apr 12 06:06:25 PDT 2015


Sure. I have just realized the patch doesn't work, because autoconf
replaces [[ ]] with [ ].

Marek

On Sun, Apr 12, 2015 at 2:48 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi Marek,
>
> On 11 April 2015 at 20:11, Marek Olšák <maraeo at gmail.com> wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> ---
>>  configure.ac | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 4ed4b74..113fb49 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -421,7 +421,9 @@ if test "x$enable_debug" = xyes; then
>>          fi
>>      fi
>>  else
>> -   DEFINES="$DEFINES -DNDEBUG"
>> +   if [[ $DEFINES != *"-DDEBUG"* ]]; then
>> +      DEFINES="$DEFINES -DNDEBUG"
>> +   fi
> Can you use test and/or case for this kind of evaluations. Iirc using
> [[ ]] is considered bash-ism, which might not be as portable.
>
>
> Thanks
> Emil


More information about the mesa-dev mailing list