[Mesa-dev] [PATCH] nir: fix bit of cargo-culting in lower_idiv

[Jason Ekstrand]

On Apr 10, 2015 1:42 PM, "Rob Clark" <robdclark at gmail.com> wrote:
>
> From: Rob Clark <robclark at freedesktop.org>
>
> I guess I was looking too much at how lower_system_values worked when
> writing lower_idiv.
>
> Since ttn wasn't emitting load_var for sysvals and the only drivers
> using lower_idiv were using ttn, I think nothing was broken as a result.
> But might as well fix this before it becomes a problem.

Yup. No harm done.

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

> Signed-off-by: Rob Clark <robclark at freedesktop.org>
> ---
>  src/glsl/nir/nir_lower_idiv.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/glsl/nir/nir_lower_idiv.c b/src/glsl/nir/nir_lower_idiv.c
> index c2f08df..7b68032 100644
> --- a/src/glsl/nir/nir_lower_idiv.c
> +++ b/src/glsl/nir/nir_lower_idiv.c
> @@ -152,6 +152,4 @@ nir_lower_idiv(nir_shader *shader)
>        if (overload->impl)
>           convert_impl(overload->impl);
>     }
> -
> -   exec_list_make_empty(&shader->system_values);
>  }
> --
> 2.1.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150410/ee3a6fa1/attachment.html>