[Mesa-dev] [Mesa-stable] [PATCH] i965: Add XRGB8888 format to intel_screen_make_configs

[Kristian Høgsberg]

On Wed, Apr 8, 2015 at 11:37 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi all,
>
> Can we get a pair of eyes on this patch please ?

Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>

Thanks for the reminder.

Kristian

>
> Boyan
> For the future can you please include the CC mesa-stable line in the
> commit message. It will make things a bit more obvious as I'm pursing
> through the list :-)
>
> Thanks
> Emil
>
> On 25 March 2015 at 11:36, Boyan Ding <boyan.j.ding at gmail.com> wrote:
>> Some application, such as drm backend of weston, uses XRGB8888 config as
>> default. i965 doesn't provide this format, but before commit 65c8965d,
>> the drm platform of EGL takes ARGB8888 as XRGB8888. Now that commit
>> 65c8965d makes EGL recognize format correctly so weston won't start
>> because it can't find XRGB8888. Add XRGB8888 format to i965 just as
>> other drivers do.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
>> Signed-off-by: Boyan Ding <boyan.j.ding at gmail.com>
>> ---
>>  src/mesa/drivers/dri/i965/intel_screen.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
>> index 3640b67..2b82c33 100644
>> --- a/src/mesa/drivers/dri/i965/intel_screen.c
>> +++ b/src/mesa/drivers/dri/i965/intel_screen.c
>> @@ -1126,7 +1126,8 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
>>  {
>>     static const mesa_format formats[] = {
>>        MESA_FORMAT_B5G6R5_UNORM,
>> -      MESA_FORMAT_B8G8R8A8_UNORM
>> +      MESA_FORMAT_B8G8R8A8_UNORM,
>> +      MESA_FORMAT_B8G8R8X8_UNORM
>>     };
>>
>>     /* GLX_SWAP_COPY_OML is not supported due to page flipping. */
>> --
>> 2.3.3
>>
>> _______________________________________________
>> mesa-stable mailing list
>> mesa-stable at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-stable
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev