[Mesa-dev] [PATCH 1/4] mesa/teximage: use correct extension for accept stencil texture.

Ilia Mirkin imirkin at alum.mit.edu
Sun Apr 5 05:46:16 PDT 2015


While this change is correct, the Intel guys will yell at you, because
they're somehow misusing this in meta for Broadwell, s.t. this will
cause crashes when blitting stencil. IMHO that's a problem that should
be fixed in their driver and this can go on, but... it's also not my
driver that's crashing -- they might feel differently :)

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Sun, Apr 5, 2015 at 2:48 AM, Dave Airlie <airlied at gmail.com> wrote:
> This was using the wrong extension, ARB_stencil_texturing
> doesn't mention any changes in this area.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/mesa/main/teximage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 8d9d7cf..36e0b56 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -222,7 +222,7 @@ _mesa_base_tex_format( struct gl_context *ctx, GLint internalFormat )
>        }
>     }
>
> -   if (ctx->Extensions.ARB_stencil_texturing) {
> +   if (ctx->Extensions.ARB_texture_stencil8) {
>        switch (internalFormat) {
>        case GL_STENCIL_INDEX:
>        case GL_STENCIL_INDEX1:
> --
> 1.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list