[PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

Dmitry Osipenko dmitry.osipenko at collabora.com
Tue Feb 28 15:28:15 UTC 2023


On 2/28/23 18:26, Thomas Zimmermann wrote:
> This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0.
> 
> The locking appears incomplete. A caller of SHMEM helper's pin
> function never acquires the dma-buf reservation lock. So we get
> 
>   WARNING: CPU: 3 PID: 967 at drivers/gpu/drm/drm_gem_shmem_helper.c:243 drm_gem_shmem_pin+0x42/0x90 [drm_shmem_helper]
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---

Thanks Thomas,

Acked-by: Dmitry Osipenko <dmitry.osipenko at collabora.com>

-- 
Best regards,
Dmitry



More information about the dri-devel mailing list