[PATCH v2 1/2] drm/vc4: replace drm_gem_dma_object for drm_gem_object in vc4_exec_info

Javier Martinez Canillas javierm at redhat.com
Tue Feb 28 10:07:07 UTC 2023


Maíra Canal <mcanal at igalia.com> writes:

Hello Maíra,

> The array of BOs that are lookup at the start of exec doesn't need
> to be instantiated as drm_gem_dma_object, as it doesn't benefit
> from its attributes. So, simplify the code by replacing the array of
> drm_gem_dma_object for an array of drm_gem_object in the struct
> vc4_exec_info.
>
> Suggested-by: Melissa Wen <mwen at igalia.com>
> Signed-off-by: Maíra Canal <mcanal at igalia.com>
> Reviewed-by: André Almeida <andrealmeid at igalia.com>
> ---

The change looks good to me and it certainly makes the code simpler.

Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



More information about the dri-devel mailing list