[PATCH 6/7] drm/gma500: Implement client-based fbdev emulation

Thomas Zimmermann tzimmermann at suse.de
Fri Feb 24 07:58:37 UTC 2023


Missing 'static inline'. Will be fixed in next rev.

Am 23.02.23 um 20:01 schrieb kernel test robot:
> Hi Thomas,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on linus/master]
> [cannot apply to drm-misc/drm-misc-next v6.2 v6.2-rc8 v6.2-rc7 next-20230223 v6.2 next-20230223]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-gma500-Remove-unnecessary-include-statements/20230223-202205
> patch link:    https://lore.kernel.org/r/20230223121733.12549-7-tzimmermann%40suse.de
> patch subject: [PATCH 6/7] drm/gma500: Implement client-based fbdev emulation
> config: i386-randconfig-a004 (https://download.01.org/0day-ci/archive/20230224/202302240250.JspOgN9W-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/intel-lab-lkp/linux/commit/d1c984af29e0c5219d353a4772527d233d1c1bcc
>          git remote add linux-review https://github.com/intel-lab-lkp/linux
>          git fetch --no-tags linux-review Thomas-Zimmermann/drm-gma500-Remove-unnecessary-include-statements/20230223-202205
>          git checkout d1c984af29e0c5219d353a4772527d233d1c1bcc
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp at intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202302240250.JspOgN9W-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>     In file included from drivers/gpu/drm/gma500/backlight.c:14:
>>> drivers/gpu/drm/gma500/psb_drv.h:620:6: warning: no previous prototype for function 'psb_fbdev_setup' [-Wmissing-prototypes]
>     void psb_fbdev_setup(struct drm_psb_private *dev_priv)
>          ^
>     drivers/gpu/drm/gma500/psb_drv.h:620:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>     void psb_fbdev_setup(struct drm_psb_private *dev_priv)
>     ^
>     static
>     1 warning generated.
> --
>     In file included from drivers/gpu/drm/gma500/psb_irq.c:15:
>>> drivers/gpu/drm/gma500/psb_drv.h:620:6: warning: no previous prototype for function 'psb_fbdev_setup' [-Wmissing-prototypes]
>     void psb_fbdev_setup(struct drm_psb_private *dev_priv)
>          ^
>     drivers/gpu/drm/gma500/psb_drv.h:620:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>     void psb_fbdev_setup(struct drm_psb_private *dev_priv)
>     ^
>     static
>     drivers/gpu/drm/gma500/psb_irq.c:35:19: warning: unused function 'gma_pipe_event' [-Wunused-function]
>     static inline u32 gma_pipe_event(int pipe)
>                       ^
>     2 warnings generated.
> 
> 
> vim +/psb_fbdev_setup +620 drivers/gpu/drm/gma500/psb_drv.h
> 
>     610	
>     611	/* framebuffer */
>     612	extern struct drm_framebuffer *psb_framebuffer_create(struct drm_device *dev,
>     613							      const struct drm_mode_fb_cmd2 *mode_cmd,
>     614							      struct drm_gem_object *obj);
>     615	
>     616	/* fbdev */
>     617	#if defined(CONFIG_DRM_FBDEV_EMULATION)
>     618	void psb_fbdev_setup(struct drm_psb_private *dev_priv);
>     619	#else
>   > 620	void psb_fbdev_setup(struct drm_psb_private *dev_priv)
>     621	{ }
>     622	#endif
>     623	
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230224/3c38673e/attachment-0001.sig>


More information about the dri-devel mailing list