[PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank
Gerd Hoffmann
kraxel at redhat.com
Mon Feb 20 15:39:10 UTC 2023
On Mon, Feb 20, 2023 at 03:22:03PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 16.02.23 um 12:33 schrieb Gerd Hoffmann:
> > On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote:
> > > Set the VGA bit for unblanking with macro constants instead of magic
> > > values. No functional changes.
> >
> > blank/unblank should work simliar to bochs (see commit 250e743915d4),
> > that is maybe a nice thing to add of you modernize the driver anyway.
> >
> > take care,
> > Gerd
> >
>
> Do you have comments on the other patches?
Checked briefly only, looked sane overall. Seems the blit and format
conversions helpers improved alot since I've added them initially (don't
follow drm that closely any more, busy with other stuff), nice to see
cirrus being updated to that and getting dirty tracking support.
Acked-by: Gerd Hoffmann <kraxel at redhat.com>
take care,
Gerd
More information about the dri-devel
mailing list