[PATCH 1/6] drm/atomic-helper: Add atomic_enable plane-helper callback

Javier Martinez Canillas javierm at redhat.com
Fri Feb 17 13:22:44 UTC 2023


Thomas Zimmermann <tzimmermann at suse.de> writes:

> Add atomic_enable to struct drm_plane_helper_funcs. It enables a
> plane independently from updating the plane's content. As such, it is
> the inverse of the atomic_disable plane helper. Useful for hardware
> where plane enable state is independent from plane content.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---

Thanks a lot for adding this. I remember wanting a plane .atomic_enable in
the past, and due not having one ended adding the enable/disable logic in
the encoder .atomic_{en,dis}able callbacks instead.

>From my understanding of the atomic state helpers the patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>

Best regards,
Javier



More information about the dri-devel mailing list