[PATCH v5 2/2] drm/imx/lcdc: Implement DRM driver for imx25

[Uwe Kleine-König]

Hello,

On Fri, Feb 10, 2023 at 07:00:14PM +0100, Uwe Kleine-König wrote:
> +	ret = drm_bridge_attach(&lcdc->pipe.encoder, lcdc->bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> +	if (ret)
> +		return dev_err_probe(drm->dev, ret, "Cannot attach bridge\n");
> +
> +	lcdc->connector = drm_bridge_connector_init(drm, &lcdc->pipe.encoder);
> +	if (IS_ERR(lcdc->connector))
> +		return dev_err_probe(drm->dev, PTR_ERR(lcdc->connector), "Cannot init bridge connector\n");
> +
> +	drm_connector_attach_encoder(lcdc->connector, &lcdc->pipe.encoder);

At one point when I talked to Philipp, we wondered if it was sensible to
create a helper function for the above sequence of drm_bridge_attach +
drm_bridge_connector_init + drm_connector_attach_encoder.

Would that make sense? What would be a good name for such a function?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230210/53c8dabc/attachment.sig>