[PATCH 1/3] drm/mediatek: Refactor pixel format logic

Justin Green greenjustin at chromium.org
Thu Feb 2 20:41:14 UTC 2023


> Yes, I had a comment on the naming in that patch. Never the less, I think if we
> don't need to "overwrite" the value, we should use just one struct for the
> values instead of copying them to the different .c files and give them SoC
> specific names.
I don't have a very strong opinion about this, and in fact that is how
v1 of the patch worked, but Chun-Kuang specifically suggested moving
that struct into the .c files a few versions back. I think it makes
sense if we expect additional skew between the different components
and what pixel formats they support.


More information about the dri-devel mailing list