[PATCH 1/4] accel/ivpu: Fix FW API data alignment issues

Jeffrey Hugo quic_jhugo at quicinc.com
Thu Feb 2 15:04:07 UTC 2023


On 2/2/2023 2:21 AM, Stanislaw Gruszka wrote:
> From: Andrzej Kacprowski <andrzej.kacprowski at linux.intel.com>
> 
> FW API structures have been updated to fix misaligned
> structure members.
> 
> Also changed JSM message header format to account for
> future improvements.
> 
> Added explicit check for minimum supported JSM API version.
> 
> Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski at linux.intel.com>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>


>   /*
>    * Job format.
> @@ -119,7 +119,7 @@ struct vpu_job_queue_entry {
>   	u64 root_page_table_update_counter; /**< Page tables update events counter */
>   	u64 preemption_buffer_address; /**< Address of the preemption buffer to use for this job */
>   	u64 preemption_buffer_size; /**< Size of the preemption buffer to use for this job */
> -	u8 reserved[VPU_JOB_RESERVED_BYTES];
> +	u8 reserved_0[VPU_JOB_RESERVED_BYTES];

This seems spurious, just adding "_0" to the name.  Seems like the 
majority of the changes are like this (although you have a _1 at the 
very end).  Are you anticipating adding additional reserved fields in 
the near future?



More information about the dri-devel mailing list