[PATCH 2/2] drm/radeon: add lockup faulty command recording

[Dave Airlie]

On Wed, May 16, 2012 at 10:22 PM,  <j.glisse at gmail.com> wrote:
> From: Jerome Glisse <jglisse at redhat.com>
>
> This try to identify the faulty user command stream that caused
> lockup. If it finds one it create big blob that contains all
> information needed to replay the faulty command stream.

Can you state what exactly is going to end up in the dump?

ring? IB? what about vertex buffers or index buffers, the thing is
should we be concentrating on replay
or just disecting the contents of the ring/IB for stupid things.

I know the Intel guys do the latter mostly and they seem to be quite
adept at finding bugs in
mesa/ddx from it, when its the obviously reproducible type of hang, as
opposed to the this GPU needs a really messed up workaround.

Otherwise I dislike the making of implicit ABI from the family and
flags, if we ever have to reorder these it will become painful,

and the whitespace cleanups should be in another patch, they make it
harder to see what is different, also pointless enum->defines.

Dave.