[Bug 45018] [bisected] rendering regression since added support for virtual address space on cayman v11

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45018

--- Comment #55 from Michel Dänzer <michel at daenzer.net> 2012-05-07 03:07:07 PDT ---
(In reply to comment #54)
> On latest git (3cd7bee48f7caf7850ea64d40f43875d4c975507), in
> src/gallium/drivers/r600/r66_hw_context.c, on line 194, shouldn't it be:
> - int offset
> + unsigned offset

That might be slightly better, but it doesn't really matter. It's the offset
from the start of the MMIO aperture, so it would only matter if the register
aperture grew beyond 2GB, which we're almost 5 orders of magnitude short of.
Very unlikely.


> Also, at line 1259, I'm not quite sure why it is shifted by 2. Most of the
> time, offset is usually shifted by 8.

It's just converting offset from units of 32 bits to bytes.


> Just looking through the code to see if something could have been missed...

Right now it would be most useful to track down why radeon_bomgr_find_va /
radeon_bomgr_force_va ends up returning the offset the kernel complains about.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.