<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv=Content-Type content="text/html; charset=us-ascii"> <meta name=Generator content="Microsoft Word 11 (filtered medium)"> <style>  </style>  </head> <body lang=EN-US link=blue vlink=purple> <div class=Section1> There's a problem in xf86scanpci that causes a seg fault on large systems. The pci_devp[] array is defined at compile time to have MAX_PCI_DEVICES + 1 elements. The loop counter variable xf86MaxPciDevs is initialized to be MAX_PCI_DEVICES, but at run time is set to the actual number of buses in the system (in linuxPci.c). On large systems, it is easy for that number to exceed the number of array elements (which causes a seg fault when scanning all the buses).<o:p></o:p> <o:p> </o:p> We opened bugzilla 10534 but haven't yet seen any responses to it. My co-worker Dan Yeisley has written a patch (see below) that fixes the problem. <o:p></o:p> <o:p> </o:p> diff -Naur xorg-server-1.1.1/hw/xfree86/os-support/bus/linuxPci.c xorg-dpy/hw/xfree86/os-support/bus/linuxPci.c<o:p></o:p> --- xorg-server-1.1.1/hw/xfree86/os-support/bus/linuxPci.c 2007-04-05 11:07:39.000000000 -0400<o:p></o:p> +++ xorg-dpy/hw/xfree86/os-support/bus/linuxPci.c 2007-04-05 11:09:18.000000000 -0400<o:p></o:p> @@ -126,7 +126,9 @@<o:p></o:p> pciFindFirstFP = pciGenFindFirst;<o:p></o:p> pciFindNextFP = pciGenFindNext;<o:p></o:p> pciSetOSBIOSPtr(linuxPciHandleBIOS);<o:p></o:p> - xf86MaxPciDevs = lnxPciInit();<o:p></o:p> + <o:p></o:p> + if (lnxPciInit() < xf86MaxPciDevs)<o:p></o:p> + xf86MaxPciDevs = lnxPciInit();<o:p></o:p> }<o:p></o:p> <o:p></o:p> static int<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <o:p> </o:p> John Magolan<o:p></o:p> Unisys Tredyffrin K205-4<o:p></o:p> <o:p></o:p> THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers.<o:p></o:p> <o:p></o:p> "You know, the only way I've found to make these pictures is with animators. You can't seem to do it with accountants and bookkeepers." —Walt Disney<o:p></o:p> <o:p></o:p> <o:p> </o:p> </div> </body> </html>