Daniel, Can this fix be checked in? A close to 2X speedup in the startup time of the X server is mucho good. --Phil <div>On 6/5/06, Thomas Leonard <<a href="mailto:tal@ecs.soton.ac.uk">tal@ecs.soton.ac.uk</a>> wrote:<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> On Sun, 04 Jun 2006 20:52:53 +0300, Daniel Stone wrote: > On Sat, Jun 03, 2006 at 02:35:18PM +0100, Thomas Leonard wrote: >> On Sat, 03 Jun 2006 15:21:11 +0300, Daniel Stone wrote: [...] >> > <a href="http://people.freedesktop.org/~daniels/xorg-pci-speedup.diff">http://people.freedesktop.org/~daniels/xorg-pci-speedup.diff</a> is extremely >> > nasty (lots of mangling between os-support/bus, and the OS subdirs), but >> > it does the trick. Does it still give you the same performance boost? >> >> No, because it still calls pciFindNext() on the last iteration of the loop... >> adding a break makes it work: >> >> if (idx == xf86OSMaxPciDevs) >> break; >> tag = pciFindNext(); > > Gotcha. Aside from that? Apart from that it works fine :-) Thanks, -- Dr Thomas Leonard <a href="http://rox.sourceforge.net">http://rox.sourceforge.net</a> GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 _______________________________________________ xorg mailing list <a href="mailto:xorg@lists.freedesktop.org">xorg@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/xorg">http://lists.freedesktop.org/mailman/listinfo/xorg</a> </blockquote></div>