X segment fault if use SW cursor

[GordonYuan at viatech.com.cn]

Dear all,

When I use SW cursor on XServer 1.6.0, there is a segment fault when
display rotation (xrandr --output xxx --rotate left). But it's OK on
XServer 1.5.2. 

I trace the codes and find the cause. The function xxx_crtc_commit will
call xf86_reload_cursors(). 

In xf86_reload_cursors(),

cursor_screen_priv = dixLookupPrivate(&screen->devPrivates,
xf86CursorScreenKey);

/* return if HW cursor is inactive, to avoid displaying two cursors */

if (!cursor_screen_priv->isUp)

return;

    In fact, if use SW cursor, I find the cursor_screen_priv is NULL.
And X accesses the null pointer. That's why segment fault come out.
Maybe we can change it to if(!cursor_screen_priv). 

    Is it a bug on XServer 1.6.0?

    Thanks!

 

Best wishes,

Gordon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg/attachments/20090407/65b8f251/attachment.html>