libXi XGetExtensionVersion does not release lock when extension is not present

[Adam Jackson]

On Tuesday 14 November 2006 13:37, Magnus Kessler wrote:
> On Monday 16 October 2006 19:00, Magnus Kessler wrote:
> > Even after the recent changes to libXi's lock handling there is still a
> > case where the lock is not correctly freed. This happens when the XInput
> > extension is not available on the server.
> >
> > I have opened bug #8663
> > (https://bugs.freedesktop.org/show_bug.cgi?id=8663) for this and attached
> > a rather large patch to it that attempts to clean up the lock handling in
> > libXi. The patch removes all lock-related side effects from internal
> > functions and also gets rid of the recursive calls between
> > _XiCheckExtInit() and _XiGetExtensionVersion().
> >
> > Please review and apply to the tree if appropriate.
>
> Has anybody had a chance to review this bug? I feel it is important to get
> this fix into 7.2 as it removes one more potential crash when using xcb. It
> also cleans up the code a bit IMHO.

The blocker bug for 7.2 is #6666.  If you mark your favorite bug as blocking 
#6666, that will guarantee that I take a look at it during the 7.2 review 
process.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20061115/c1bb181b/attachment.pgp>