PCI rework

John Hughes john at Calva.COM
Tue May 2 06:16:52 PDT 2006


Ian Romanick wrote:

> Mark Kettenis wrote:
>
> How do you figure?  The interface is modeled after the interface in
> libpci (part of pciutils), which was created long before the sysfs

^^ notice correct use of parens, space before "(", after ")"

> interface was available, and has been ported to other platforms.  There
> was quite a bit of discussion about this some months ago (in February).

^^ again.

>
> >-    *pucByte = pciReadByte(pMga->PciTag,ulOffset);
> >+    pci_device_cfg_read_u8( pMga->PciInfo, pucByte, ulOffset );
>
>
> >Oh, and I really think you shouldn't change the coding style.  Those
> >extra spaces after the the '(' are just plain ugly ;-).
>
>
> Yeah,beingabletoactuallyreadthecodeissuchahorriblething. :P


No, to make the code readable follow the typographical conventions that
have been used for decades, if not centuries.





More information about the xorg mailing list