AM_PRETTY_CMDS and unofficial macros? (was Re: [ANNOUNCE] libXmu 1.0.3)

[Jeremy C. Reed]

> On Sat, Dec 09, 2006 at 07:49:01AM -0600, Jeremy C. Reed wrote:
> > Where did you get this AM_PRETTY_CMDS (pretty-cmds)?
> > 
> > It is not portable. Its use of "test" doesn't even work with test(1) from 
> > coreutils. (And doesn't work with built-in "test" found in some shells.)
> > 
> > The bug is not in libXmu itself but in your released version of configure 
> > and aclocal.m4 included in this tarball.
> > 
> > I emailed the fix upstream to 
> > http://kim.tensta.gannert.se/projects/pretty-am/
> 
> Hi,
> Could you please attach the patch here for posterity?

Sorry, I don't have your original macro file (and there is no fix for any 
component of Xorg as this came from outside).

Anyways the fix is simply to use a single equal (=) instead of two equals 
(==) when using "test".

Here is patch for configure, but that doesn't do us any good as configure 
is not part of Xorg:

--- configure.orig	2006-12-09 12:45:30.000000000 +0100
+++ configure
@@ -2252,10 +2252,10 @@ AMSHOWCMDSAT=''
 AMDEPSHOWCMDSAT=''
 AMPRETTYECHO=true
 AMCMDECHO=echo
-if test "x$enable_pretty_cmds" == xyes;
+if test "x$enable_pretty_cmds" = xyes;
 then
   AMSHOWCMDSAT='@'
-  test x$enable_dependency_tracking == xno && AMDEPSHOWCMDSAT='@'
+  test x$enable_dependency_tracking = xno && AMDEPSHOWCMDSAT='@'
   AMPRETTYECHO=echo
   AMCMDECHO=true
   LT_QUIET='--quiet'

The upstream developer of this unofficial patch replied to me and is 
fixing it. I don't know where you got your version (maybe shipped with 
Debian) but hopefully that is fixed soon too.