use of tet_fork (hard part)

Jamey Sharp jamey at minilop.net
Tue Dec 20 21:38:32 EET 2005


Please see my other tet_fork message for background.

XCloseDisplay-6 also uses tet_fork incorrectly, but my current patch for
it causes test FAILs and I don't understand why. As it stands now, this
test opens two connections, then shares one of them between the parent
and child. Here's my strategy pseudo-code change from the patch:

 >>STRATEGY
 Create a connection for client1 using XOpenDisplay.
 Create a connection for client2 using XOpenDisplay.
+Create a connection for client3 using XOpenDisplay.
 Create a window using XCreateWindow.
 Grab the server for the default display using XGrabServer.
 Create a process using tet_fork.
 In child process:
-   Generate a ChangeProperty request using XChangeProperty.
+   Generate a ChangeProperty request as client3 using XChangeProperty.
 Wait sufficient time for the ChangeProperty request to be processed.
-Verify that no PropertyChange event has been generated by client2 using XCheckWindowEvent.
+Verify as client1 that no PropertyChange event has been generated by client3 using XCheckWindowEvent.
 Close the client1 connection using xname.
 Wait suffient time for the ChangeProperty request to be processed.
-Verify that a ChangeProperty request was generated by client2.
+Verify as client2 that a ChangeProperty request was generated by client3.

It seems to me that this test does not need to fork, so I think the best
patch would be to rewrite the strategy to use a single process; but
Keithp told me to go for a minimal diff, so I tried to do that.

I'd appreciate advice on how to correct this test.

--Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.x.org/archives/xorg-test/attachments/20051220/691bc4c9/attachment.pgp 


More information about the xorg-test mailing list