Hello, <div class="gmail_quote">On Wed, Jun 9, 2010 at 11:23 AM, Chris Ball <<a href="mailto:cjb@laptop.org">cjb@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Hi, <div class="im"> > On Wed, Jun 9, 2010 at 7:52 AM, Chris Ball <<a href="mailto:cjb@laptop.org">cjb@laptop.org</a>> wrote: >> It's better to e-mail patches inline rather than attached, one >> e-mail per patch, so that it's easy to comment on specific parts >> of them. > Please, no. Having to extract inline patches to commit to GIT is > a real PITA. </div>Sorry, I still disagree -- the Xorg community rejects attached patches in general, so we shouldn't be recommending them here. Inline patches are much easier to review line-by-line. As a compromise, if it helps, I'm happy to volunteer to do the importing of Frank's patches into git. It's just two commands for me; save the whole mail into a file, and git-am thatfile. </blockquote></div> Same hassle for me; so I offer help if need. -- Otavio Salvador O.S. Systems E-mail: <a href="mailto:otavio@ossystems.com.br">otavio@ossystems.com.br</a> <a href="http://www.ossystems.com.br">http://www.ossystems.com.br</a> Mobile: +55 53 9981-7854 <a href="http://projetos.ossystems.com.br">http://projetos.ossystems.com.br</a>