[Xorg-driver-geode] looking at wide mode support for GeodeLX (continued)
Bart Trojanowski
bart at jukie.net
Wed Feb 13 08:48:16 PST 2008
Hi Jordan,
* Jordan Crouse <jordan.crouse at amd.com> [080211 14:44]:
> Attached is a patch to only go through Cimarron and Durango mode validation
> if the mode flags are set to DEFAULT or BUILTIN. Anything else
> especially (USERDEF and DRIVER) should pass right through.
>
> This is neither compile tested nor tested on hardware, so please do so and
> let me know.
I have not yet reviewed the patch. I just applied it and ran it on top
of gutsy w/ 2.6.6.7 and my CPUID patch in xorg.
Running X with no modes set in the xorg.conf puts my monitor into
1280x1024. All the other modes are rejected, and in the log I see
things like:
(II) AMD(0): Not using default mode "1280x800" (-2/unknown reason)
... the -2 is MODE_BAD returned by LXValidMode().
Making the change below makes higher modes work again.
-Bart
diff --git a/src/amd_lx_driver.c b/src/amd_lx_driver.c
index c779ac1..313b45d 100644
--- a/src/amd_lx_driver.c
+++ b/src/amd_lx_driver.c
@@ -1420,7 +1420,7 @@ LXValidMode(int scrnIndex, DisplayModePtr pMode, Bool Verbose, int flags)
ret = vg_get_display_mode_index(&vgQueryMode);
- if (ret < 0)
+ if (pGeode->Output & OUTPUT_PANEL && ret < 0)
return MODE_BAD;
}
More information about the Xorg-driver-geode
mailing list