[PATCH 03/11] drmmode: add drmmode_get_current_ust function

Richard Wilbur richard.wilbur at gmail.com
Sun Apr 28 17:40:24 PDT 2013


On Sun, Apr 28, 2013 at 2:07 PM, Ilija Hadzic <ilijahadzic at gmail.com> wrote:
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index 13e65fa..2b61823 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -216,6 +217,30 @@ drmmode_ConvertToKMode(ScrnInfoPtr scrn,
[...]
> +/*
> + * Retrieves present time in milliseconds that is compatible
> + * with units used by vblank timestamps. Depending on the kernel
> + * version and DRM kernel module configuration, the vblank
> + * timestamp can either be in real time or monotonic time
> + */
> +int drmmode_get_current_ust(int drm_fd, CARD64 *ust)
> +{
[...]
> +       *ust = ((CARD64)now.tv_sec * 1000000) + ((CARD64)now.tv_nsec / 1000);
> +       return 0;
> +}

I'd like to suggest changing the comment as follows   s/milli/micro/  ->
> + * Retrieves present time in microseconds that is compatible

so that the comment matches the math (millisecond = ms = 10^-3 s,
microsecond = us = 10^-6 s) and the function name "*_ust".

Sincerely,

Richard


More information about the xorg-driver-ati mailing list