[PATCH xf86-video-r128] Add EXA support

Michel Dänzer michel at daenzer.net
Tue Jul 17 01:43:41 PDT 2012


On Mon, 2012-07-16 at 12:56 -0700, Connor Behan wrote: 
> This introduces EXA acceleration which can improve performance and allow
> 2D acceleration to be used without XAA. Implemented hooks are Solid,
> Copy and Composite. They appear to pass all rendercheck tests, except
> the gradient test which XAA also fails. Tested on multiple color depths,
> with and without DRI, with and without the composite extension. Hardware
> cursor, Xvideo and page flipping are supported as well.
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=47866
> 
> Signed-off-by: Connor Behan <connor.behan at gmail.com>

[...]

> diff --git a/src/r128.h b/src/r128.h
> index bee1562..9b2556f 100644
> --- a/src/r128.h
> +++ b/src/r128.h
> @@ -83,6 +118,8 @@
>  #define R128_VBIOS_SIZE 0x00010000
>  
>  #if R128_DEBUG
> +#include "r128_version.h"
> +
>  #define R128TRACE(x)                                          \
>      do {                                                      \
>  	ErrorF("(**) %s(%d): ", R128_NAME, pScrn->scrnIndex); \

I think this hunk should be in the other patch.


> diff --git a/src/r128_cursor.c b/src/r128_cursor.c
> index 62d277d..974a6d5 100644
> --- a/src/r128_cursor.c
> +++ b/src/r128_cursor.c
[...] 
> +    if ((!info->useEXA && !fbarea) || (info->useEXA && !osArea)) {

osArea is undeclared here if EXA is disabled at build time.


Anyway, I figured this has been dragging on for too long, so I pushed it
with the r128_version.h inclusion dropped.

Thanks!


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-driver-ati mailing list