<div dir="ltr">Hi,<div class="gmail_extra"><br><div class="gmail_quote">On 16 December 2014 at 04:43, Peter Hutterer <span dir="ltr"><<a href="mailto:peter.hutterer@who-t.net" target="_blank">peter.hutterer@who-t.net</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@@ -1157,18 +1139,6 @@ GetKeyboardEvents(InternalEvent *events, DeviceIntPtr pDev, int type,<br>
set_key_up(pDev, key_code, KEY_POSTED);<br>
}<br>
<br>
- clipValuators(pDev, &mask);<br>
-<br>
- set_valuators(pDev, event, &mask);<br>
-<br>
- if (!IsFloating(pDev)) {<br>
- DeviceIntPtr master = GetMaster(pDev, MASTER_POINTER);<br>
-<br>
- event_set_root_coordinates(event,<br>
- master->last.valuators[0],<br>
- master->last.valuators[1]);<br>
- }<br>
-<br>
return num_events;<br>
}<br></blockquote><div><br></div><div>Are you sure this is right? Won't this change it from returning root_[xy] with current MD pointer co-ordinates to nothing/rubbish?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">diff --git a/hw/xfree86/common/xf86Module.h b/hw/xfree86/common/xf86Module.h<br>
index e68fe9c..25a8869 100644<br>
--- a/hw/xfree86/common/xf86Module.h<br>
+++ b/hw/xfree86/common/xf86Module.h<br>
@@ -81,7 +81,7 @@ typedef enum {<br>
*/<br>
#define ABI_ANSIC_VERSION SET_ABI_VERSION(0, 4)<br>
#define ABI_VIDEODRV_VERSION SET_ABI_VERSION(19, 0)<br>
-#define ABI_XINPUT_VERSION SET_ABI_VERSION(21, 0)<br>
+#define ABI_XINPUT_VERSION SET_ABI_VERSION(22, 0)<br>
#define ABI_EXTENSION_VERSION SET_ABI_VERSION(9, 0)<br>
#define ABI_FONT_VERSION SET_ABI_VERSION(0, 6)<br>
<br>
diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c<br>
index 1fb5b16..9fa3dc4 100644<br>
--- a/hw/xfree86/common/xf86Xinput.c<br>
+++ b/hw/xfree86/common/xf86Xinput.c<br>
@@ -1326,47 +1326,21 @@ xf86PostButtonEventM(DeviceIntPtr device,<br>
}<br>
<br>
void<br>
-xf86PostKeyEvent(DeviceIntPtr device,<br>
- unsigned int key_code,<br>
- int is_down,<br>
- int is_absolute, int first_valuator, int num_valuators, ...)<br>
+xf86PostKeyEvent(DeviceIntPtr device, unsigned int key_code, int is_down)</blockquote><div><br></div><div>I'd probably lean towards leaving the xf86 wrappers alone (with a BUG_ON if you must); not sure the annoyance of an ABI break to essentially preserve the status quo is worth it tbh.</div><div><br></div><div>Cheers,</div><div>Daniel</div></div></div></div>