<div dir="ltr"><div><div><div><div>Hi Christian,<br><br></div>thank you for having a look. The original patch is from Jonas Petersen. You will find all necessary information in the links below:<br>   orginal:<a href="https://freedesktop.org/patch/16753/">https://freedesktop.org/patch/16753/</a></div><div>   latest:   <a href="https://freedesktop.org/patch/33513/">https://freedesktop.org/patch/33513/</a></div><div><br></div><div>I got involved just because I happen to have a critical application which is not allowed to crash, let alone after less than 24 hrs:<br></div><div><a href="http://lists.x.org/archives/xorg-devel/2014-August/043661.html">http://lists.x.org/archives/xorg-devel/2014-August/043661.html</a><br><br><br></div>other references:<br><a href="https://bugs.freedesktop.org/show_bug.cgi?id=71338">https://bugs.freedesktop.org/show_bug.cgi?id=71338</a><br><a href="http://lists.x.org/archives/xorg-devel/2013-October/038370.html">http://lists.x.org/archives/xorg-devel/2013-October/038370.html</a><br><a href="https://freedesktop.org/patch/15500/">https://freedesktop.org/patch/15500/</a><br><br></div>best regards,<br></div>Jan<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 4 November 2014 13:55, Christian Linhart <span dir="ltr"><<a href="mailto:chris@demorecorder.com" target="_blank">chris@demorecorder.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    Hi Jan,<br>
    <br>
    Can you please repost your patch together with a description of the
    problem and your approach to fix it.<br>
    <br>
    I was not subscribed to that list back when you have posted it, and
    so may some others, who may be able to move this thing forward. You
    may also post a link to the specific mails/threads in the
    mailinglist-archives if that'll help with understanding your patch.<br>
    <br>
    I'll look at that then.<br>
    <br>
    I have some other issues with sequence numbers, and I think we need
    to solve that on a design level.<br>
    The essential thing is that the protocol transports only 16-bit
    sequence numbers, but server and client work with at least 32-bit,
    sometimes 64-bit sequence numbers. What I've seen so far in the code
    looks like heuristics which may fail in some cases. Maybe I am
    missing something. In any case, I want to see your problem analysis
    and your proposed fix before I propose something.<br>
    <br>
    Chris<div><div class="h5"><br>
    <br>
    On 11/04/14 13:14, Jan Smout wrote:
    <blockquote type="cite">
      <div dir="ltr">
        <div><br>
        </div>
        I already forked it for myself a couple of months ago. As long
        as I control the packages which get installed on the machines I
        have no real issue... except for an uncomfortable feeling that
        if things like this don't get fixed, what other dragons might be
        hiding deep down in the xlib library?<br>
        Now, when somebody would want to run the application on their
        own install, that's where the shit hits the fan. I'll be forced
        to tell them to downgrade their xlib to 1.3.3 and file a
        complaint on this list :-)<br>
        <br>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On 4 November 2014 10:49, Alexander
            E. Patrakov <span dir="ltr"><<a href="mailto:patrakov@gmail.com" target="_blank">patrakov@gmail.com</a>></span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div text="#000000" bgcolor="#FFFFFF"> Just fork it. I am
                sure that such antisocial step is the only way forward,
                because I also have a patch that was not looked at for
                too long, and then rejected because it breaks keystone
                correction (which was broken in a different way before
                the patch).
                <div>
                  <div><br>
                    <br>
                    <div>04.11.2014 13:23, Jan Smout wrote:<br>
                    </div>
                  </div>
                </div>
                <blockquote type="cite">
                  <div>
                    <div>
                      <div dir="ltr">and again... reminder...<br>
                      </div>
                      <div class="gmail_extra"><br>
                        <div class="gmail_quote">On 28 October 2014
                          12:51, Jan Smout <span dir="ltr"><<a href="mailto:smout.jan@gmail.com" target="_blank">smout.jan@gmail.com</a>></span>
                          wrote:<br>
                          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                            <div dir="ltr">reminder...<br>
                            </div>
                            <div>
                              <div>
                                <div class="gmail_extra"><br>
                                  <div class="gmail_quote">On 21 October
                                    2014 12:49, Jan Smout <span dir="ltr"><<a href="mailto:smout.jan@gmail.com" target="_blank">smout.jan@gmail.com</a>></span>
                                    wrote:<br>
                                    <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                                      <div dir="ltr">
                                        <div>
                                          <div><br>
                                          </div>
                                          Keith, we are approaching the
                                          one year anniversary of this
                                          bug already. Maybe it is time
                                          to finish the patch and leave
                                          the issue behind?<br>
                                          <br>
                                          <br>
                                        </div>
                                        <div>fyi, I have been running my
                                          application with the first
                                          version of Jonas's patch for
                                          65 days straight now without a
                                          glitch (it used to crash in
                                          less than 20 hours).<br>
                                          <br>
                                        </div>
                                        <div>I also intend to restart
                                          this long duration test once
                                          the final patch will be
                                          released<br>
                                          <br>
                                        </div>
                                      </div>
                                      <div class="gmail_extra"><br>
                                        <div class="gmail_quote"><span>On
                                            27 September 2014 05:23,
                                            Keith Packard <span dir="ltr"><<a href="mailto:keithp@keithp.com" target="_blank">keithp@keithp.com</a>></span>
                                            wrote:<br>
                                          </span>
                                          <div>
                                            <div>
                                              <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                                                <div>
                                                  <div>Matt Turner <<a href="mailto:mattst88@gmail.com" target="_blank">mattst88@gmail.com</a>>

                                                    writes:<br>
                                                    <br>
                                                    > On Fri, Sep 26,
                                                    2014 at 3:40 AM, Jan
                                                    Smout <<a href="mailto:smout.jan@gmail.com" target="_blank">smout.jan@gmail.com</a>>

                                                    wrote:<br>
                                                    >> Keith
                                                    Packard doesn't seem
                                                    very responsive (as
                                                    in 'completely
                                                    ignoring the<br>
                                                    >> subject')<br>
                                                    ><br>
                                                    > Perhaps you
                                                    should try Ccing
                                                    him? (now Cc'd)<br>
                                                    <br>
                                                  </div>
                                                </div>
                                                The problem is that
                                                reviewing this patch is
                                                *really hard*. The last<br>
                                                time, I think I spent a
                                                solid couple of days
                                                thinking about this and<br>
                                                making sure I'd caught
                                                all of the cases. I'm
                                                still not sure it's
                                                right,<br>
                                                but I guess it's
                                                probably better than
                                                what we have?<br>
                                                <span><font color="#888888"><br>
                                                    --<br>
                                                    <a href="mailto:keith.packard@intel.com" target="_blank">keith.packard@intel.com</a><br>
                                                  </font></span></blockquote>
                                            </div>
                                          </div>
                                        </div>
                                        <br>
                                        <br clear="all">
                                        <span><br>
                                          -- <br>
                                          Life is complex, it has a real
                                          part and an imaginary part. </span></div>
                                    </blockquote>
                                  </div>
                                  <br>
                                  <br clear="all">
                                  <br>
                                  -- <br>
                                  Life is complex, it has a real part
                                  and an imaginary part. </div>
                              </div>
                            </div>
                          </blockquote>
                        </div>
                        <br>
                        <br clear="all">
                        <br>
                        -- <br>
                        <div>Life is complex, it has a real part and an
                          imaginary part.</div>
                      </div>
                      <br>
                      <fieldset></fieldset>
                      <br>
                    </div>
                  </div>
                  <span>
                    <pre>_______________________________________________
<a href="mailto:xorg-devel@lists.x.org" target="_blank">xorg-devel@lists.x.org</a>: X.Org development
Archives: <a href="http://lists.x.org/archives/xorg-devel" target="_blank">http://lists.x.org/archives/xorg-devel</a>
Info: <a href="http://lists.x.org/mailman/listinfo/xorg-devel" target="_blank">http://lists.x.org/mailman/listinfo/xorg-devel</a></pre>
                  </span></blockquote>
                <br>
              </div>
            </blockquote>
          </div>
          <br>
          <br clear="all">
          <br>
          -- <br>
          <div>Life is complex, it has a real
            part and an imaginary part.</div>
        </div>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      <pre>_______________________________________________
<a href="mailto:xorg-devel@lists.x.org:" target="_blank">xorg-devel@lists.x.org:</a> X.Org development
Archives: <a href="http://lists.x.org/archives/xorg-devel" target="_blank">http://lists.x.org/archives/xorg-devel</a>
Info: <a href="http://lists.x.org/mailman/listinfo/xorg-devel" target="_blank">http://lists.x.org/mailman/listinfo/xorg-devel</a></pre>
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">Life is complex, it has a real part and an imaginary part.</div>
</div>