<div dir="ltr">No? He removed the brace so it's a one-line if body.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 27, 2014 at 4:34 PM, Keith Packard <span dir="ltr"><<a href="mailto:keithp@keithp.com" target="_blank">keithp@keithp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">Adam Jackson <<a href="mailto:ajax@redhat.com">ajax@redhat.com</a>> writes:<br>
<br>
> No functional change.<br>
><br>
> Signed-off-by: Adam Jackson <<a href="mailto:ajax@redhat.com">ajax@redhat.com</a>><br>
> ---<br>
>  composite/compinit.c | 27 ++++++++++++++++-----------<br>
>  1 file changed, 16 insertions(+), 11 deletions(-)<br>
><br>
> diff --git a/composite/compinit.c b/composite/compinit.c<br>
> index 111c16e..7daf171 100644<br>
> --- a/composite/compinit.c<br>
> +++ b/composite/compinit.c<br>
> @@ -104,6 +104,20 @@ compInstallColormap(ColormapPtr pColormap)<br>
>      pScreen->InstallColormap = compInstallColormap;<br>
>  }<br>
><br>
> +static void<br>
> +compCheckBackingStore(WindowPtr pWin)<br>
> +{<br>
> +    if (pWin->backingStore != NotUseful && !pWin->backStorage) {<br>
> +        compRedirectWindow(serverClient, pWin, CompositeRedirectAutomatic);<br>
> +        pWin->backStorage = TRUE;<br>
> +    }<br>
> +    else if (pWin->backingStore == NotUseful && pWin->backStorage) {<br>
> +        compUnredirectWindow(serverClient, pWin,<br>
> +                             CompositeRedirectAutomatic);<br>
> +        pWin->backStorage = FALSE;<br>
> +    }<br>
> +}<br>
> +<br>
>  /* Fake backing store via automatic redirection */<br>
>  static Bool<br>
>  compChangeWindowAttributes(WindowPtr pWin, unsigned long mask)<br>
> @@ -116,17 +130,8 @@ compChangeWindowAttributes(WindowPtr pWin, unsigned long mask)<br>
>      ret = pScreen->ChangeWindowAttributes(pWin, mask);<br>
><br>
>      if (ret && (mask & CWBackingStore) &&<br>
> -        pScreen->backingStoreSupport != NotUseful) {<br>
> -        if (pWin->backingStore != NotUseful && !pWin->backStorage) {<br>
> -            compRedirectWindow(serverClient, pWin, CompositeRedirectAutomatic);<br>
> -            pWin->backStorage = TRUE;<br>
> -        }<br>
> -        else if (pWin->backingStore == NotUseful && pWin->backStorage) {<br>
> -            compUnredirectWindow(serverClient, pWin,<br>
> -                                 CompositeRedirectAutomatic);<br>
> -            pWin->backStorage = FALSE;<br>
> -        }<br>
> -    }<br>
> +        pScreen->backingStoreSupport != NotUseful)<br>
> +        compCheckBackingStore(pWin);<br>
><br>
<br>
</div></div>Looks like this is missing a } here?<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
<a href="mailto:keith.packard@intel.com">keith.packard@intel.com</a><br>
</font></span><br>_______________________________________________<br>
<a href="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</a>: X.Org development<br>
Archives: <a href="http://lists.x.org/archives/xorg-devel" target="_blank">http://lists.x.org/archives/xorg-devel</a><br>
Info: <a href="http://lists.x.org/mailman/listinfo/xorg-devel" target="_blank">http://lists.x.org/mailman/listinfo/xorg-devel</a><br></blockquote></div><br><br clear="all"><br>-- <br>  Jasper<br>
</div>