<div dir="ltr"><div>I sort of like "slide" because it gives the impression that we copy the framebuffer contents if the size of the window hasn't changed. That said, if we want to change this, we should change the name of the slot too.<br><br></div><div>Reviewed-by: Jasper St. Pierre <<a href="mailto:jstpierre@mecheye.net">jstpierre@mecheye.net</a>><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 23, 2014 at 12:32 PM, Adam Jackson <span dir="ltr"><<a href="mailto:ajax@redhat.com" target="_blank">ajax@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Make the function name match the screen slot name.<br>
<br>
Signed-off-by: Adam Jackson <<a href="mailto:ajax@redhat.com">ajax@redhat.com</a>><br>
---<br>
mi/mi.h | 12 ++++++------<br>
mi/miscrinit.c | 2 +-<br>
mi/miwindow.c | 5 ++---<br>
3 files changed, 9 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/mi/mi.h b/mi/mi.h<br>
index 8cb3ce7..5a455c9 100644<br>
--- a/mi/mi.h<br>
+++ b/mi/mi.h<br>
@@ -470,12 +470,12 @@ extern _X_EXPORT void miMoveWindow(WindowPtr /*pWin */ ,<br>
VTKind /*kind */<br>
);<br>
<br>
-extern _X_EXPORT void miSlideAndSizeWindow(WindowPtr /*pWin */ ,<br>
- int /*x */ ,<br>
- int /*y */ ,<br>
- unsigned int /*w */ ,<br>
- unsigned int /*h */ ,<br>
- WindowPtr /*pSib */<br>
+extern _X_EXPORT void miResizeWindow(WindowPtr /*pWin */ ,<br>
+ int /*x */ ,<br>
+ int /*y */ ,<br>
+ unsigned int /*w */ ,<br>
+ unsigned int /*h */ ,<br>
+ WindowPtr /*pSib */<br>
);<br>
<br>
extern _X_EXPORT WindowPtr miGetLayerWindow(WindowPtr /*pWin */<br>
diff --git a/mi/miscrinit.c b/mi/miscrinit.c<br>
index ec4d108..327bd15 100644<br>
--- a/mi/miscrinit.c<br>
+++ b/mi/miscrinit.c<br>
@@ -264,7 +264,7 @@ miScreenInit(ScreenPtr pScreen, void *pbits, /* pointer to screen bits */<br>
pScreen->MarkWindow = miMarkWindow;<br>
pScreen->MarkOverlappedWindows = miMarkOverlappedWindows;<br>
pScreen->MoveWindow = miMoveWindow;<br>
- pScreen->ResizeWindow = miSlideAndSizeWindow;<br>
+ pScreen->ResizeWindow = miResizeWindow;<br>
pScreen->GetLayerWindow = miGetLayerWindow;<br>
pScreen->HandleExposures = miHandleValidateExposures;<br>
pScreen->ReparentWindow = (ReparentWindowProcPtr) 0;<br>
diff --git a/mi/miwindow.c b/mi/miwindow.c<br>
index ba4c9ed..cfe085a 100644<br>
--- a/mi/miwindow.c<br>
+++ b/mi/miwindow.c<br>
@@ -337,9 +337,8 @@ miRecomputeExposures(WindowPtr pWin, void *value)<br>
}<br>
<br>
void<br>
-miSlideAndSizeWindow(WindowPtr pWin,<br>
- int x, int y,<br>
- unsigned int w, unsigned int h, WindowPtr pSib)<br>
+miResizeWindow(WindowPtr pWin, int x, int y, unsigned int w, unsigned int h,<br>
+ WindowPtr pSib)<br>
{<br>
WindowPtr pParent;<br>
Bool WasViewable = (Bool) (pWin->viewable);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.3<br>
<br>
_______________________________________________<br>
<a href="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</a>: X.Org development<br>
Archives: <a href="http://lists.x.org/archives/xorg-devel" target="_blank">http://lists.x.org/archives/xorg-devel</a><br>
Info: <a href="http://lists.x.org/mailman/listinfo/xorg-devel" target="_blank">http://lists.x.org/mailman/listinfo/xorg-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br> Jasper<br>
</div>