<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 14-03-22 03:27 PM, Jon TURNEY wrote: </div> <blockquote cite="mid:532DE417.3060704@dronecode.org.uk" type="cite"> <pre wrap="">On 19/03/2014 21:29, Gaetan Nadon wrote: </pre> <blockquote type="cite"> <pre wrap="">On 14-03-03 10:08 AM, Jon TURNEY wrote: </pre> <blockquote type="cite"> <pre wrap="">Build fbcmap_mi.c once, rather than for each DDX, and make it part of libfb or libwfb convenience library. Since 84e8de1271bb11b5b4b9747ae4647f47333a8ab7 we don't have fbcmap.c This is a sort of revert of 7ecc2d526c4ea5db2589644a2fec0daf71df36da </pre> </blockquote> <pre wrap=""> kdrive fbdev fails because libkdrivestubs is added in configure.ac. Consider this change: diff --git a/configure.ac b/configure.ac index 162c0cf..d7a55a4 100644 --- a/configure.ac +++ b/configure.ac @@ -2400,8 +2400,7 @@ if test "$KDRIVE" = yes; then fi ;; esac - KDRIVE_STUB_LIB='$(top_builddir)/hw/kdrive/src/libkdrivestubs.la' - KDRIVE_LOCAL_LIBS="$MAIN_LIB $DIX_LIB $KDRIVE_LIB $KDRIVE_STUB_LIB" + KDRIVE_LOCAL_LIBS="$MAIN_LIB $DIX_LIB $KDRIVE_LIB" KDRIVE_LOCAL_LIBS="$KDRIVE_LOCAL_LIBS $FB_LIB $MI_LIB $KDRIVE_PURE_LIBS" KDRIVE_LOCAL_LIBS="$KDRIVE_LOCAL_LIBS $KDRIVE_OS_LIB" KDRIVE_LIBS="$KDRIVE_LOCAL_LIBS $XSERVER_SYS_LIBS $GLX_SYS_LIBS $DLOPEN_LIB </pre> </blockquote> <pre wrap=""> Thanks. Squashed this into revised patch attached. </pre> <blockquote type="cite"> <pre wrap="">It looks like Xnest does not need libfb at all which is set in configure.ac. It does not cause any problem, however. </pre> </blockquote> <pre wrap=""> I guess that makes some kind of sense. </pre> </blockquote> Reviewed-by: Gaetan Nadon <a class="moz-txt-link-rfc2396E" href="mailto:memsize@videotron.ca"><memsize@videotron.ca></a> Feel free to review/scoop <blockquote><tt>[PATCH RESEND xserver] test: create a link to the generated hw/xfree86/sdksyms.c at build time</tt><tt> </tt></blockquote> It's also to fix the subdir-objects issue in future automake versions. </body> </html>