<div dir="ltr"><div>So, I know this is existing practice, but it seems to me that building with different protocol headers than what the server supports would only lead to disaster.<br><br></div><div>Do we do this anywhere already?<br>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 13, 2013 at 12:05 PM, Adam Jackson <span dir="ltr"><<a href="mailto:ajax@redhat.com" target="_blank">ajax@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We want to advertise the version we implement, not the version the<br>
protocol headers happen to describe.<br>
<br>
Signed-off-by: Adam Jackson <<a href="mailto:ajax@redhat.com">ajax@redhat.com</a>><br>
---<br>
include/protocol-versions.h | 4 ++++<br>
present/present_request.c | 5 +++--<br>
2 files changed, 7 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/include/protocol-versions.h b/include/protocol-versions.h<br>
index 7fe61e0..fc428c8 100644<br>
--- a/include/protocol-versions.h<br>
+++ b/include/protocol-versions.h<br>
@@ -67,6 +67,10 @@<br>
#define SERVER_PANORAMIX_MAJOR_VERSION 1<br>
#define SERVER_PANORAMIX_MINOR_VERSION 1<br>
<br>
+/* Present */<br>
+#define SERVER_PRESENT_MAJOR_VERSION 1<br>
+#define SERVER_PRESENT_MINOR_VERSION 0<br>
+<br>
/* RandR */<br>
#define SERVER_RANDR_MAJOR_VERSION 1<br>
#define SERVER_RANDR_MINOR_VERSION 4<br>
diff --git a/present/present_request.c b/present/present_request.c<br>
index 095fa2d..1064dcb 100644<br>
--- a/present/present_request.c<br>
+++ b/present/present_request.c<br>
@@ -26,6 +26,7 @@<br>
<br>
#include "present_priv.h"<br>
#include "randrstr.h"<br>
+#include <protocol-versions.h><br>
<br>
static int<br>
proc_present_query_version(ClientPtr client)<br>
@@ -35,8 +36,8 @@ proc_present_query_version(ClientPtr client)<br>
.type = X_Reply,<br>
.sequenceNumber = client->sequence,<br>
.length = 0,<br>
- .majorVersion = PRESENT_MAJOR,<br>
- .minorVersion = PRESENT_MINOR<br>
+ .majorVersion = SERVER_PRESENT_MAJOR_VERSION,<br>
+ .minorVersion = SERVER_PRESENT_MINOR_VERSION<br>
};<br>
<br>
REQUEST_SIZE_MATCH(xPresentQueryVersionReq);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.4.2<br>
<br>
_______________________________________________<br>
<a href="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</a>: X.Org development<br>
Archives: <a href="http://lists.x.org/archives/xorg-devel" target="_blank">http://lists.x.org/archives/xorg-devel</a><br>
Info: <a href="http://lists.x.org/mailman/listinfo/xorg-devel" target="_blank">http://lists.x.org/mailman/listinfo/xorg-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br> Jasper<br>
</div>