<div dir="ltr">Please consider this small change in patch after Mark Kettenis' comment:<div><br></div><div><div><div>diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c</div><div>index 91ec4c8..0517c16 100644</div>
<div>--- a/hw/xfree86/common/xf86Init.c</div><div>+++ b/hw/xfree86/common/xf86Init.c</div><div>@@ -544,7 +544,8 @@ InitOutput(ScreenInfo * pScreenInfo, int argc, char **argv)</div><div> if (NEED_IO_ENABLED(flags))</div>
<div> want_hw_access = TRUE;</div><div><br></div><div>- if (!(flags & HW_SKIP_CONSOLE))</div><div>+ /* Non-seat0 X servers should not open console */</div><div>+ if (!((flags & HW_SKIP_CONSOLE) || ServerIsNotSeat0()))</div>
<div> xorgHWOpenConsole = TRUE;</div><div> }</div><div><br></div><div>-- </div><div>1.8.1.4</div></div></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div dir="ltr">CANTATE DOMINO CANTICUM NOVUM<div>
QUIA MIRABILIA FECIT</div><div><br></div><div>Laércio</div></div></div>
<br><br><div class="gmail_quote">2013/12/12 Laércio de Sousa <span dir="ltr"><<a href="mailto:lbsousajr@gmail.com" target="_blank">lbsousajr@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Done:<div><br></div><div><a href="http://lists.x.org/archives/xorg-devel/2013-December/039567.html" target="_blank">http://lists.x.org/archives/xorg-devel/2013-December/039567.html</a><br></div></div><div class="gmail_extra">
<div class="im">
<br clear="all"><div><div dir="ltr">CANTATE DOMINO CANTICUM NOVUM<div>QUIA MIRABILIA FECIT</div><div><br></div><div>Laércio</div></div></div>
<br><br></div><div class="gmail_quote"><div class="im">2013/12/12 Hans de Goede <span dir="ltr"><<a href="mailto:hdegoede@redhat.com" target="_blank">hdegoede@redhat.com</a>></span><br></div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<div><br>
<br>
On 12/12/2013 02:31 PM, Laércio de Sousa wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hans,<br>
<br>
systemd currently ships a multi-seat-x wrapper (<a href="http://cgit.freedesktop.org/systemd/systemd/tree/src/login/multi-seat-x.c" target="_blank">http://cgit.freedesktop.org/<u></u>systemd/systemd/tree/src/<u></u>login/multi-seat-x.c</a>) for cases where X.Org doesn't work well with multiseat. In the beginning, it was much bigger, but now, as X.Org evolves, it now only does the following:<br>
<br>
* If "-seat" option value is "seat0", just exec real X server, with no additions<br>
* Otherwise:<br>
+ Append "-sharevts" to real X server command line [*]<br>
+ Append "-config" to real X server command line, with the following config file:<br>
Section "ServerFlags"<br>
Option "AutoAddDevices" "True" # pointless, since it's already true by default<br>
Option "AllowEmptyInput" "True" # this option doesn't exist anymore<br>
Option "DontVTSwitch" "True" [*]<br>
EndSection<br>
Section "InputClass"<br>
Identifier "Force Input Devices to Seat"<br>
Option "GrabDevice" "True" # not needed anymore, since <a href="http://cgit.freedesktop.org/xorg/xserver/commit/?id=c73c36b537f996574628e69681833ea37dec2b6e" target="_blank">http://cgit.freedesktop.org/<u></u>xorg/xserver/commit/?id=<u></u>c73c36b537f996574628e69681833e<u></u>a37dec2b6e</a><br>
EndSection<br>
<br>
The points tagged with [*] above are needed because non-seat0 X servers still try to open VTs, although non-seat0 seats can't handle them. My patch proposed at <a href="http://lists.x.org/archives/xorg-devel/2013-December/039353.html" target="_blank">http://lists.x.org/archives/<u></u>xorg-devel/2013-December/<u></u>039353.html</a> makes those points unneeded.<br>
</blockquote>
<br></div>
Thanks for the explanation, I've one small nitpick on your patch,<br>
if you can resend it with that fixed I'll add it to what is swiftly growing<br>
into my systemd integration tree :)<br>
<br>
--- a/hw/xfree86/common/xf86Init.c<br>
+++ b/hw/xfree86/common/xf86Init.c<br>
@@ -545,7 +545,8 @@ InitOutput(ScreenInfo * pScreenInfo, int argc, char **argv)<br>
want_hw_access = TRUE;<br>
<br>
if (!(flags & HW_SKIP_CONSOLE))<br>
- xorgHWOpenConsole = TRUE;<br>
+ /* Non-seat0 X servers should not open console */<br>
+ xorgHWOpenConsole = !ServerIsNotSeat0();<br>
}<br>
<br>
if (xorgHWOpenConsole)<br>
<br>
Can you please make the !ServerIsNotSeat0() part of the if condition,<br>
rather then using it as the value to store ? Since this is just<br>
another way of expressing SKIP_CONSOLE it seems more sensible to me<br>
that way.<br>
<br>
Thanks & Regards,<br>
<br>
Hans<br>
</blockquote></div></div></div><br></div>
</blockquote></div><br></div>