<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 13-11-27 02:50 AM, Ran Benita wrote:<br>
</div>
<blockquote cite="mid:20131127075010.GA571@ran" type="cite">
<pre wrap="">Hi Gaetan,
On Tue, Nov 26, 2013 at 07:02:23PM -0500, Gaetan Nadon wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 13-11-26 06:33 PM, Ran Benita wrote:
</pre>
<blockquote type="cite">
<pre wrap="">This was already committed, but how about changing to AC_CC_C99 instead?
</pre>
</blockquote>
<pre wrap="">Pardon me as I am out of context. The xserver module is configured with
AC_PROG_CC_C99 that gets pulled in by XORG_DEFAULTS from util-macros.
It's not obvious, but it saves from copying this line in the 250 xorg
modules.
</pre>
</blockquote>
<pre wrap="">
Problem is, xcb doesn't use util-macros. I like it myself.</pre>
</blockquote>
ooops, I was indeed out of context. Usually [PATCH] without a name
implies xserver.<br>
<blockquote cite="mid:20131127075010.GA571@ran" type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">That's why we ask developers not to add AC_PROG_CC in configure.ac as it
turns the module back to C89. That isn't obvious either :-)
To find which of the two a module is using:
grep "^CC=" config.status
and you get:
CC='gcc -std=gnu99'
There are also a couple of options to fine tune the level of strictness:
--disable-selective-werror
Turn off selective compiler errors. (default:
enabled)
</pre>
</blockquote>
<pre wrap="">
Didn't know about this one, used to do this manually sometimes.</pre>
</blockquote>
Added in 2011 by Jeremy Huddleston<br>
<blockquote>
<div class="commit-subject"><tt>Provide a configure option to turn
off the selective -Werror=... CFLAGS<br>
<br>
</tt></div>
<tt>Provide end users with a workaround if they find code doesn't
build with
the -Werror=... flags provided by BASE_CFLAGS. This can be
useful if
newer util-macros are used with older source code that had
problems, or
in the rare case when warnings are expanded to hit more cases
(although
this case should not happen too much in practice).<br>
</tt></blockquote>
<br>
Cheers!<br>
<blockquote>
</blockquote>
<blockquote cite="mid:20131127075010.GA571@ran" type="cite">
<blockquote type="cite">
<pre wrap="">_______________________________________________
<a class="moz-txt-link-abbreviated" href="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</a>: X.Org development
Archives: <a class="moz-txt-link-freetext" href="http://lists.x.org/archives/xorg-devel">http://lists.x.org/archives/xorg-devel</a>
Info: <a class="moz-txt-link-freetext" href="http://lists.x.org/mailman/listinfo/xorg-devel">http://lists.x.org/mailman/listinfo/xorg-devel</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>