<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 13-11-26 06:33 PM, Ran Benita wrote: </div> <blockquote cite="mid:20131126233317.GA24947@ran" type="cite"> <pre wrap="">This was already committed, but how about changing to AC_CC_C99 instead?</pre> </blockquote> Pardon me as I am out of context. The xserver module is configured with AC_PROG_CC_C99 that gets pulled in by XORG_DEFAULTS from util-macros. It's not obvious, but it saves from copying this line in the 250 xorg modules. That's why we ask developers not to add AC_PROG_CC in configure.ac as it turns the module back to C89. That isn't obvious either :-) To find which of the two a module is using: <blockquote><tt>grep "^CC=" config.status</tt> </blockquote> and you get: <blockquote><tt>CC='gcc -std=gnu99'</tt> </blockquote> There are also a couple of options to fine tune the level of strictness: <blockquote> --disable-selective-werror Turn off selective compiler errors. (default: enabled) --enable-strict-compilation Enable all warnings from compiler and make them errors (default: disabled) </blockquote> I took this opportunity to explain this non obvious configuration to all. <blockquote cite="mid:20131126233317.GA24947@ran" type="cite"> <pre wrap=""> pedantic _can_ be useful for XCB imo, e.g. the "enum too big for an int" thing. Also, the code already uses some C99 constructs now. </pre> </blockquote> </body> </html>