<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 13-11-01 01:56 PM, Aaron Plattner
wrote:<br>
</div>
<blockquote
cite="mid:1383328616-3120-1-git-send-email-aplattner@nvidia.com"
type="cite">
<pre wrap="">These new packages are needed by xserver.
Signed-off-by: Aaron Plattner <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:aplattner@nvidia.com"><aplattner@nvidia.com></a>
---
build.sh | 3 +++
1 file changed, 3 insertions(+)
</pre>
</blockquote>
<br>
I am out of context here, but these looks like prototypes from a
packaging point of view. Could you bring them up to spec? Any other
xorg protos and libs can be used to copy and fix up. Otherwise it
would take dozens of patches to fix them up.<br>
<br>
Everything is explained in details here:<br>
<a class="moz-txt-link-freetext" href="http://www.x.org/wiki/NewModuleGuidelines/">http://www.x.org/wiki/NewModuleGuidelines/</a><br>
<br>
<br>
.gitignore is wrong, copy the one used in any of the xorg modules<br>
Missing COPYING file<br>
missing README file<br>
<br>
libshmfence:<br>
<br>
<pre><code>AC_PREREQ([2.57]) should be 2.60
AC_FATAL is really old. Please copy the whole paragraph from any modules already in build.sh
Don't set AC_PROG_CC, bad.
Don't write XORG_CWARNFLAGS in configure.ac.
This is bad too:
</code>
<code><code>XORG_RELEASE_VERSION
XORG_CHANGELOG</code>
</code></pre>
Missing:<br>
<br>
<pre><code>XORG_MACROS_VERSION(1.3)
XORG_DEFAULT_OPTIONS</code></pre>
This use of AC_OUTPUT is deprecated use AC_CONFIG_FILES<br>
<br>
The Makefile.am does need to put ChangeLog in EXTRA_DIST<br>
Copy the snippet from another module.<br>
<br>
This code is really ancient. Please copy from any lib xorg has
shipped recently.<br>
<br>
I'll be happy to review the changes and help if anything is unclear,
but it should only take a few minutes to fix.<br>
<br>
</body>
</html>