<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 13-10-18 09:01 AM, Thomas Klausner wrote: </div> <blockquote cite="mid:20131018130114.GA10327@danbala.tuwien.ac.at" type="cite"> <pre wrap="">On Fri, Oct 18, 2013 at 08:28:48AM -0400, Gaetan Nadon wrote: </pre> <blockquote type="cite"> <pre wrap="">On 13-10-18 04:57 AM, Thomas Klausner wrote: </pre> <blockquote type="cite"> <pre wrap="">On Sat, Oct 05, 2013 at 01:56:58AM +0200, Thomas Klausner wrote: </pre> <blockquote type="cite"> <pre wrap="">Alan Coopersmith offered me push access to xorg more than two months ago; I filed a bug report[1] according to procedure, which has been sitting there since August 1. Alan and I have been trying to contact admins he knows, but there was no real response to that either. Does anyone know a way to make progress with this? </pre> </blockquote> <pre wrap="">Since I got no feedback, and the report is still not handled, could some please push my open patches? (details available on request) Thomas </pre> </blockquote> <pre wrap="">I can push signed-off patches having a Reviewed-by tag. </pre> </blockquote> <pre wrap=""> Great. Can you please take a look at my series of 23 patches for</pre> </blockquote> make that 24 :-) <blockquote cite="mid:20131018130114.GA10327@danbala.tuwien.ac.at" type="cite"> <pre wrap=""> xf86-input-keyboard, sent on July 29, first Message-Id Message-Id: <a class="moz-txt-link-rfc2396E" href="mailto:1375133029-1678-2-git-send-email-wiz@NetBSD.org"><1375133029-1678-2-git-send-email-wiz@NetBSD.org></a></pre> </blockquote> Message id confirmed. I still have the series in my reader. I applied the original pacth 18 + patch 24 from the attachement. <blockquote><tt>Applying: Use existing wscons USB keymap for WSKBD_TYPE_MAPLE on dreamcast.</tt><tt> </tt><tt>Applying: Add a couple mappings for keys found on Sun keyboards.</tt><tt> </tt><tt>Applying: Fix scan code 50 key on non-US-USB keyboards.</tt><tt> </tt><tt>Applying: Add a basic map for an LK201 keyboard.</tt><tt> </tt><tt>Applying: Set the version for the keyboard.</tt><tt> </tt><tt>Applying: Fix a shadowing warning, and add const.</tt><tt> </tt><tt>Applying: Recognize WSKBD_TYPE_MAPLE for dreamcast.</tt><tt> </tt><tt>Applying: Add default device for Protocol "wskbd".</tt><tt> </tt><tt>Applying: Add WSKBD_TYPE_LK201.</tt><tt> </tt><tt>Applying: Make OpenKeyboard() warn instead of error out.</tt><tt> </tt><tt>Applying: Fix wskbd handling when VT switching.</tt><tt> </tt><tt>/home/nadon/xorg/src/driver/xf86-input-keyboard/.git/rebase-apply/patch:18: space before tab in indent.</tt><tt> </tt><tt> if ((pKbd->wsKbdDev[0] != 0) && (pInfo->fd == -1)) {</tt><tt> </tt><tt>/home/nadon/xorg/src/driver/xf86-input-keyboard/.git/rebase-apply/patch:45: space before tab in indent.</tt><tt> </tt><tt> xf86Msg(X_INFO, "closing %s\n", pKbd->wsKbdDev);</tt><tt> </tt><tt>/home/nadon/xorg/src/driver/xf86-input-keyboard/.git/rebase-apply/patch:46: space before tab in indent.</tt><tt> </tt><tt> /* need to close the fd while we're gone */</tt><tt> </tt><tt>/home/nadon/xorg/src/driver/xf86-input-keyboard/.git/rebase-apply/patch:47: space before tab in indent.</tt><tt> </tt><tt> close(pInfo->fd);</tt><tt> </tt><tt>/home/nadon/xorg/src/driver/xf86-input-keyboard/.git/rebase-apply/patch:48: space before tab in indent.</tt><tt> </tt><tt> pInfo->fd = -1;</tt><tt> </tt><tt>warning: squelched 1 whitespace error</tt><tt> </tt><tt>warning: 6 lines add whitespace errors.</tt><tt> </tt><tt>Applying: Improve auto-detection.</tt><tt> </tt><tt>Applying: Move WSCONS case inside switch statement.</tt><tt> </tt><tt>Applying: Add some NetBSD feature detection code.</tt><tt> </tt><tt>Applying: Do not assume type in WS_*_MAP_SIZE macros.</tt><tt> </tt><tt>Applying: Factor out common code.</tt> <tt>Applying: Check open() return value.</tt> </blockquote> Should I attempt to fix the whitespace errors? (I'll be out for few hours) <blockquote cite="mid:20131018130114.GA10327@danbala.tuwien.ac.at" type="cite"> <pre wrap=""> They are all reviewed by at least one, sometimes two people. I can send them to you again directly, if you prefer, just let me know. Thank you, Thomas </pre> </blockquote> </body> </html>