<div dir="ltr">Could we just remove ROOTLESS_PROTECT_ALPHA entirely?<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 20, 2013 at 3:33 PM, Adam Jackson <span dir="ltr"><<a href="mailto:ajax@redhat.com" target="_blank">ajax@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ROOTLESS_RESIZE_GRAVITY is an optimization, so let's default it to off<br>
unless the backing window system is known to support it.<br>
<br>
ROOTLESS_PROTECT_ALPHA looks like it has different values for xquartz<br>
and win32, but hilariously rootlessGC.c merely checks if it is defined,<br>
not what the value is. It's effectively the more conservative path<br>
anyway, so let's just turn it on.<br>
<br>
Signed-off-by: Adam Jackson <<a href="mailto:ajax@redhat.com">ajax@redhat.com</a>><br>
---<br>
miext/rootless/rootlessConfig.h | 19 ++++---------------<br>
1 file changed, 4 insertions(+), 15 deletions(-)<br>
<br>
diff --git a/miext/rootless/rootlessConfig.h b/miext/rootless/rootlessConfig.h<br>
index d39ae63..4c464b9 100644<br>
--- a/miext/rootless/rootlessConfig.h<br>
+++ b/miext/rootless/rootlessConfig.h<br>
@@ -35,28 +35,17 @@<br>
#define _ROOTLESSCONFIG_H<br>
<br>
#ifdef __APPLE__<br>
+#define ROOTLESS_RESIZE_GRAVITY TRUE<br>
+#endif<br>
+<br>
+/*# define ROOTLESSDEBUG*/<br>
<br>
#define ROOTLESS_PROTECT_ALPHA TRUE<br>
#define ROOTLESS_REDISPLAY_DELAY 10<br>
-#define ROOTLESS_RESIZE_GRAVITY TRUE<br>
-/*# define ROOTLESSDEBUG*/<br>
<br>
/* Bit mask for alpha channel with a particular number of bits per<br>
pixel. Note that we only care for 32bpp data. Mac OS X uses planar<br>
alpha for 16bpp. */<br>
#define RootlessAlphaMask(bpp) ((bpp) == 32 ? 0xFF000000 : 0)<br>
<br>
-#endif /* __APPLE__ */<br>
-<br>
-#if defined(__CYGWIN__) || defined(WIN32)<br>
-<br>
-#define ROOTLESS_PROTECT_ALPHA NO<br>
-#define ROOTLESS_REDISPLAY_DELAY 10<br>
-#undef ROOTLESS_RESIZE_GRAVITY<br>
-/*# define ROOTLESSDEBUG*/<br>
-<br>
-#define RootlessAlphaMask(bpp) ((bpp) == 32 ? 0xFF000000 : 0)<br>
-<br>
-#endif /* __CYGWIN__ */<br>
-<br>
#endif /* _ROOTLESSCONFIG_H */<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.3.1<br>
<br>
_______________________________________________<br>
<a href="mailto:xorg-devel@lists.x.org">xorg-devel@lists.x.org</a>: X.Org development<br>
Archives: <a href="http://lists.x.org/archives/xorg-devel" target="_blank">http://lists.x.org/archives/xorg-devel</a><br>
Info: <a href="http://lists.x.org/mailman/listinfo/xorg-devel" target="_blank">http://lists.x.org/mailman/listinfo/xorg-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br> Jasper<br>
</div>