<p dir="ltr">Since every other XTHREADS check in that earlier patch uses #ifdef, it looks like it was just a mistake.</p>
<p dir="ltr">For this fix:<br>
Reviewed-by: Jamey Sharp <<a href="mailto:jamey@minilop.net">jamey@minilop.net</a>></p>
<p dir="ltr">Jamey</p>
<div class="gmail_quot<blockquote class=" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 06/ 2/13 11:49 AM, Thomas Klausner wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/XlibInt.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/XlibInt.c b/src/XlibInt.c<br>
index b06e57b..92a4340 100644<br>
--- a/src/XlibInt.c<br>
+++ b/src/XlibInt.c<br>
@@ -239,7 +239,7 @@ void _XSeqSyncFunction(<br>
static int<br>
_XPrivSyncFunction (Display *dpy)<br>
{<br>
-#if XTHREADS<br>
+#ifdef XTHREADS<br>
assert(!dpy->lock_fns);<br>
#endif<br>
assert(dpy->synchandler == _XPrivSyncFunction);<br>
<br>
</blockquote>
<br>
The comment right before that function is:<br>
/* NOTE: only called if !XTHREADS, or when XInitThreads wasn't called. */<br>
which makes this sound intentional, but since even in the old monolith<br>
I only see XTHREADS being defined or undefined, not defined with a false<br>
value, I'm not sure when that would be hit.<br>
<br>
Since Jamey just added this in 2010, we can ask him and see if he remembers<br>
why he did used #if instead of #ifdef:<br>
<br>
<a href="http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=a6d974dc59f2722b36e2df9d4f07aeee4f83ce43" target="_blank">http://cgit.freedesktop.org/<u></u>xorg/lib/libX11/commit/?id=<u></u>a6d974dc59f2722b36e2df9d4f07ae<u></u>ee4f83ce43</a><br>
<br>
-- <br>
-Alan Coopersmith- <a href="mailto:alan.coopersmith@oracle.com" target="_blank">alan.coopersmith@oracle.com</a><br>
Oracle Solaris Engineering - <a href="http://blogs.oracle.com/alanc" target="_blank">http://blogs.oracle.com/alanc</a><br>
</div>